Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fixes "no-redundant-jsdoc" exception on this tag #4690

Merged
merged 1 commit into from
May 15, 2019

Conversation

bugsduggan
Copy link
Contributor

@bugsduggan bugsduggan commented May 1, 2019

The 'no-redundant-jsdoc' rule threw an error in 'some-file.ts':
Error: Unexpected tag kind: JSDocThisTag

This appears to be similar to #3413

PR checklist

  • Addresses an existing issue: fixes #0000
  • [ x ] New feature, bugfix, or enhancement
    • [ x ] Includes tests
  • Documentation update

Overview of change:

Adds JSDocThisTag to the redundant cases.

Is there anything you'd like reviewers to focus on?

I appreciate this is my first contribution to this project so feel free to point me in the direction of any contribution guidelines that I've overlooked.

CHANGELOG.md entry:

[bugfix] no-redundant-jsdoc no longer errors on JSDocThisTag

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @bugsduggan! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems nice and clean (thanks!); just waiting on a corresponding test.

src/rules/noRedundantJsdocRule.ts Show resolved Hide resolved
```
The 'no-redundant-jsdoc' rule threw an error in 'some-file.ts':
Error: Unexpected tag kind: JSDocThisTag
```

This appears to be similar to palantir#3413
@bugsduggan bugsduggan force-pushed the fix-no-redundant-jsdoc-error branch from aa3e31c to 57a52a2 Compare May 7, 2019 06:36
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bugsduggan

@adidahiya adidahiya merged commit 8ef652e into palantir:master May 15, 2019
@bugsduggan bugsduggan deleted the fix-no-redundant-jsdoc-error branch May 16, 2019 06:23
@adidahiya adidahiya mentioned this pull request May 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants