-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Vue3 using compat release #88
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awesome, will take a look over the weekend 🥰 |
paulgoetze
commented
Dec 10, 2021
paulgoetze
force-pushed
the
try-vue3-compat-release
branch
from
December 10, 2021 17:07
41bd4f9
to
7523ad6
Compare
paulgoetze
force-pushed
the
try-vue3-compat-release
branch
from
December 10, 2021 19:16
7523ad6
to
46a937a
Compare
janlelis
approved these changes
Dec 10, 2021
pascalwengerter
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like charm for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of PR #85 with some additional fixes.
Thanks @pascalwengerter for the ground work! 🙌. For some reason i18n worked now - maybe some fixes where made meanwhile.
I was not sure how to get my fixes on top of yours, so I just copied your branch from your fork & opened this new PR.
Fixes #83
Fixes #85