Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify type for wrapper arguments #156

Merged
merged 1 commit into from
May 6, 2024
Merged

simplify type for wrapper arguments #156

merged 1 commit into from
May 6, 2024

Conversation

davidism
Copy link
Member

@davidism davidism commented May 6, 2024

Use Callable types instead of Protocol. Protocol wasn't matching Flask's async_to_sync function, causing typing to fail over there, even though the signatures appear to be correct. I wish something about typing was simple for once.

@davidism davidism merged commit 952a97b into main May 6, 2024
8 checks passed
@davidism davidism deleted the wrapper-type branch May 6, 2024 16:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant