Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring up URI check for sqlite engine #1315

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sparrow0hawk
Copy link

Changes

This PR brings up the check for a SQLite URI within the _apply_driver_defaults function to allow for earlier detection of if the database should run in-memory.

It adds a test to check that a database file is not created when using a SQLite URI filename for an in-memory database.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

Includes a test to check that a database file is not created when using
sqlite URI for in memory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Using SQLite URI filename format for in-memory database still creates a file
2 participants