Skip to content

Commit

Permalink
Merge pull request #2237 from pallets/param-order
Browse files Browse the repository at this point in the history
restore Path param order
  • Loading branch information
davidism authored Mar 31, 2022
2 parents a66119a + b36bf8f commit 77dd30f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ Unreleased

- Fix error message for readable path check that was mixed up with the
executable check. :pr:`2236`
- Restore parameter order for ``Path``, placing the ``executable``
parameter at the end. It is recommended to use keyword arguments
instead of positional arguments. :issue:`2235`


Version 8.1.1
Expand Down
4 changes: 2 additions & 2 deletions src/click/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -790,12 +790,12 @@ def __init__(
exists: bool = False,
file_okay: bool = True,
dir_okay: bool = True,
readable: bool = True,
writable: bool = False,
executable: bool = False,
readable: bool = True,
resolve_path: bool = False,
allow_dash: bool = False,
path_type: t.Optional[t.Type] = None,
executable: bool = False,
):
self.exists = exists
self.file_okay = file_okay
Expand Down

0 comments on commit 77dd30f

Please sign in to comment.