Remove deprecation warnings for add_etags & mimetype guessing for send_file() #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests pass even if the deprecation warnings are not removed. That means they were ineffective from the beginning. I'll investigate this. |
|
Thanks! I applied your changes to master. |
| @@ -553,7 +538,9 @@ def send_file(filename_or_fp, mimetype=None, as_attachment=False, | |||
| rv.cache_control.max_age = cache_timeout | |||
| rv.expires = int(time() + cache_timeout) | |||
|
|
|||
| if add_etags and filename is not None: | |||
| if add_etags and filename is not None and file is None: | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
untitaker
added a commit
that referenced
this pull request
Aug 20, 2016
untitaker
added a commit
that referenced
this pull request
Aug 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.