Disable logger propagation by default

[mitsuhiko]

Main motivation for this is that logging.basicConfig() otherwise logs
all things twice by default since the logger propagates upwards to the
default handler.

---

This change is

[untitaker]

I feel like a single logging handler should be used at the root.

[mitsuhiko]

@untitaker you mean remove our own default handler entirely? Generelly I would like to merge this for next release. It tremendously improves what happens if you configure sentry/raven/bugsnag etc.

[untitaker]

Yeah exactly that. What does sentry do wrt logging?

[mitsuhiko]

@untitaker sentry is not that important. Anything that configures the logging system will break currently. You can just issue logging.basicConfig() and you get all exceptions twice. It just shows up with those things like sentry more because errors are reported twice there in the UI. (Though sentry is less affected since it dedupes in the raven client. Others do not).

[untitaker]

I feel like you haven't really said what you think of this, or why it is not an alternative:

I feel like a single logging handler should be used at the root.

[mitsuhiko]

@untitaker as i said I'm not sure what you mean by that. Do you mean we should not configure our own log handler? Because we can't change what logging.basicConfig() does which does install a default handler.

[untitaker]

I replied with "yeah exactly that"

[untitaker]

Also note that I don't have any opinion on that topic, this is just for
the sake of having evaluated all alternatives <3

On Sun, Sep 11, 2016 at 01:24:54AM -0700, Armin Ronacher wrote:

@untitaker as i said I'm not sure what you mean by that. Do you mean we should not configure our own log handler? Because we can't change what logging.basicConfig() does which does install a default handler.

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#1993 (comment)

[mitsuhiko]

I will merge this.

[untitaker]

I would still like to hear some sort of rationale, longer or shorter. Not because I want to educate myself at the expense of your time, but because I think it will serve as a useful reference when later this behavior will possibly be changed again.