configure and check request.trusted_hosts
#5637
Merged
+40
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
TRUSTED_HOSTS
config. InFlask.create_url_adapter
, which is called when creating aRequestContext
, setrequest.trusted_hosts
to the config. Callget_host
with the config, and assign it torequest.host
to pre-cache the property.I considered making
flask.Request.trusted_hosts
a property, so that setting it would trigger validation again automatically. I'm not confident this difference in behavior from Werkzeug, where only accessingrequest.host
triggers validation, would be good. If it's a good idea, it can be done in Werkzeug.fixes #5636