Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise SignatureExpired error when age is in the future #133

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Raise SignatureExpired error when age is in the future #133

merged 1 commit into from
Apr 17, 2020

Conversation

zhugnou
Copy link
Contributor

@zhugnou zhugnou commented Jun 1, 2019 •
edited by davidism
Loading

Fixes #126. This conditional checks that the age is not a future date.

jab
jab approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@jab jab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Thanks for the fix, @zhugnou!

davidism
davidism approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@davidism davidism left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and test looks good. Need to add a changelog.

merwok
merwok reviewed Jan 7, 2020
View reviewed changes
src/itsdangerous/timed.py Outdated Show resolved Hide resolved
@davidism davidism added this to the 2.0.0 milestone Apr 14, 2020
@davidism davidism force-pushed the zhugnou/issue-126 branch 2 times, most recently from 3c6a5a0 to 84f4949 Compare April 15, 2020 00:27
@davidism davidism merged commit 542fad1 into pallets:master Apr 17, 2020
@davidism davidism mentioned this pull request Jan 29, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@merwok merwok merwok left review comments

@adisakshya adisakshya adisakshya approved these changes

@davidism davidism davidism approved these changes

@jab jab jab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

TimedSerializer accepts timestamps from the future
5 participants
@zhugnou @jab @merwok @davidism @adisakshya