Make CodeGenerator and Context overridable #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
added a commit
to ThiefMaster/jinja
that referenced
this pull request
Apr 6, 2015
ThiefMaster
added a commit
to ThiefMaster/jinja
that referenced
this pull request
Apr 6, 2015
ThiefMaster
added a commit
to ThiefMaster/jinja
that referenced
this pull request
Apr 6, 2015
ThiefMaster
added a commit
to ThiefMaster/jinja
that referenced
this pull request
Apr 6, 2015
ThiefMaster
force-pushed
the
override-codegen-context
branch
from
95eb002
to
f22fdd5
Compare
|
I'm really confused by your commit referencing the PR itself but the diff checks out. |
|
Initially I was going to open a separate PR, then I remembered that the |
ThiefMaster
force-pushed
the
override-codegen-context
branch
from
f22fdd5
to
abf025e
Compare
|
I see, I thought that functionality has been removed from Github. |
|
It's deprecated (not sure why, seems to be useful) according to the output of the command:
|
|
Thanks, merged! |
|
Regarding that hub feature: mislav/hub@4f70dd1 |
ThiefMaster
added a commit
to ThiefMaster/flask
that referenced
this pull request
Apr 6, 2015
This is useful e.g. when using the new Jinja Environment attributes added in pallets/jinja#404
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably not needed very often, but subclassing e.g. the Environment to use a custom class for it would be so much cleaner than having to monkey-patch or fork.