Fix bug in TypeConversionDict #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During conversion, TypeConversionDict should propagate errors from the converter (except ValueError) Signed-off-by: Antonio Ossa <[email protected]>
This new test class includes three testcases: 1) Tests that the value conversion works, 2) tests that the default value is returned when conversion is not possible, and 3) tests that exceptions rased during conversions are propagated Signed-off-by: Antonio Ossa <[email protected]>
Signed-off-by: Antonio Ossa <[email protected]>
davidism
approved these changes
Apr 15, 2017
|
Right on, thanks! |
ThiefMaster
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1102 and discussion in #1106
Fix #1102
Replaces #1106