match header option value with single quotes #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Dec 5, 2017
| 'form-data; name="file"; filename="t\'es\'t.txt"' | ||
| ) == ('form-data', {'name': 'file', 'filename': "t'es't.txt"}) | ||
| assert http.parse_options_header( | ||
| 'form-data; name="file"; filename*=UTF-8\'\'"\'🐍\'.txt"' |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This was referenced Dec 7, 2017
This was referenced Jan 5, 2018
This was referenced Jan 15, 2018
This was referenced Jan 29, 2018
This was referenced Feb 5, 2018
This was referenced Feb 13, 2018
This was referenced Feb 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
*=into the match for extended notation, instead of before it.The regex became slightly stricter and no longer matches
*=if it's not followed by a language and encoding. For example,filename*=test.txtno longer matches (although it was never valid and nothing should have been sending that). Allowing that (against spec) and also fixing the quoting issue would require a different solution.fixes #1091, fixes #1177