forked from ARMmbed/mbed-os
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nordic cordio support #6
Open
ghost
wants to merge
7
commits into
pan-:ble-extended-advertising
Choose a base branch
from
unknown repository
base: ble-extended-advertising
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-
requested changes
Nov 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scartmell-arm Could you replace uses of us_ticker
API with the Timer
API ?
features/FEATURE_BLE/targets/TARGET_CORDIO/stack/mbed_os_adaptation/wsf_os.c
Outdated
Show resolved
Hide resolved
pan-
reviewed
Nov 22, 2018
@paul-szczepanek-arm could you review ? |
features/FEATURE_BLE/targets/TARGET_CORDIO/source/CordioBLE.cpp
Outdated
Show resolved
Hide resolved
pan-
force-pushed
the
ble-extended-advertising
branch
from
November 26, 2018 10:25
622061f
to
8cbc536
Compare
features/FEATURE_BLE/targets/TARGET_CORDIO/source/CordioBLE.cpp
Outdated
Show resolved
Hide resolved
features/FEATURE_BLE/targets/TARGET_CORDIO/source/CordioBLE.cpp
Outdated
Show resolved
Hide resolved
NRF52480 fails to complete BLE initialisation due to attempting to set more event handlers than are supported by the WSF library. Increasing the number of handlers fixes this issue.
The function wsfOsReadyToSleep should only be called when interrupts are disabled. Entering a critical section before calling the function fixes any potential issues.
Enumeration values were removed in 78d4a9b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Patch Cordio BLE to work correctly with NRF52840.
Pull request type