New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a edge case for testSwap #43

Merged

chefburger merged 1 commit into main from fix/testSwap

May 13, 2024

Collaborator

chefburger commented May 13, 2024 •

edited

Loading

This should fix #38

Context:

The error happens when:

swapParams.amountSpecified is greater than type(int128).max i.e. 170141183460469231731687303715884105727
Pool has enough liquidity to digest all the amountSpecified
In this case, amountSpecified will be exactly either balanceDelta.amount0 or balanceDelta.amount1 which is int128
It results in the call toInt128() failed


          fix: a edge case for testSwap

a053fda

ChefMist approved these changes

View reviewed changes

chefburger merged commit 8c19261 into main

2 checks passed

chefburger deleted the fix/testSwap branch

May 13, 2024 08:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet