Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIFT-660: Implement export time series data as .dp and csv files #2

Merged
merged 9 commits into from
Feb 20, 2023

Conversation

atimin
Copy link
Member

@atimin atimin commented Feb 14, 2023

Closes #

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md have been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

Feature

What is the current behavior?

No export.

What is the new behavior?

A use can use drfit-cli export rawcommand to export data from blob storage as Drift packages or CSV files if it is time series data.

Does this PR introduce a breaking change?

No

Other information:

@pmalessa
Copy link

Please add example for ISO time string

--stop TEXT   Export records  with timestamps older than this time point in
                ISO format (e.g. 2023-01-23T14:18:59Z)

@pmalessa
Copy link

Please correct that example in docs/export.md to ISO time string
drift-cli export raw drift-device ./exported-data --start 2021-01-01 --end 2021-01-02

@pmalessa
Copy link

There is a typo in the --cvs. option

@pmalessa
Copy link

pmalessa commented Feb 16, 2023

image

The warnings for "not a time series" appear on top of the progress bars, once it tries to download the first packet. However, it is still marked as "waiting". Should be marked as "skipped" So, instead of creating a separate warning just add it to the download progress bar

@atimin
Copy link
Member Author

atimin commented Feb 20, 2023

image The warnings for "not a time series" appear on top of the progress bars, once it tries to download the first packet. However, it is still marked as "waiting". Should be marked as "skipped" So, instead of creating a separate warning just add it to the download progress bar

I really love your "just".

@atimin atimin merged commit e5efda9 into develop Feb 20, 2023
@atimin atimin deleted the drift-660 branch February 20, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants