Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Action to assign issues fails when quotes are present #29768

Closed
ivirshup opened this issue Nov 21, 2019 · 8 comments · Fixed by #31237
Closed

CI: Action to assign issues fails when quotes are present #29768

ivirshup opened this issue Nov 21, 2019 · 8 comments · Fixed by #31237
Assignees
Labels
CI Continuous Integration good first issue

Comments

@ivirshup
Copy link
Contributor

So, this is a little weird. Apparently I left such a bad comment on an issue, it failed CI 😄.

I'm not sure how it got triggered, but looks like it's from a recently added workflow. The CI error has the contents of my comment, and I got an email that looks like this:

Notification email

Run failed for master (6d11aa8)

Repository: pandas-dev/pandas
Workflow: Assign
Duration: 16.0 seconds
Finished: 2019-11-21 05:41:26 UTC

View results

Jobs:
cb4db6dd-e658-55b7-b337-8761517bc1a3 failed (1 annotation)

You are receiving this because this workflow ran on your branch.
Manage your GitHub Actions notifications here.


Looks like this might be related to #29648, @datapythonista?

@WillAyd
Copy link
Member

WillAyd commented Nov 21, 2019

This isn't coming from pandas but your local branch right? We did add GH actions recently so it might fail on your branch if not set up

@datapythonista datapythonista added the CI Continuous Integration label Nov 21, 2019
@datapythonista datapythonista changed the title CI failed my comment? CI: Action to assign issues fails when quotes are present Nov 21, 2019
@datapythonista
Copy link
Member

Thanks for reporting this @ivirshup. We have an action that assigns issues if a comment with the exact text take is written. Looks like it fails when comments that are evaluated are compared, since quotes are not escaped.

@tigerey3
Copy link

I would like to work on this issue given that it's still unassigned!

@datapythonista
Copy link
Member

Sure, thanks for the help! It's assigned to you, you can assign issues to yourself by writing a comment with just take

@tigerey3 tigerey3 removed their assignment Nov 23, 2019
@datavizard
Copy link

take

@lithomas1
Copy link
Member

Is anyone still working on this? If not, I can take it.

@datapythonista
Copy link
Member

I don't think anyone is working on this, and should be a fast task. Unassigned the issue.

@lithomas1
Copy link
Member

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants