Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Adding GitHub action to assign issues based on comment #29648

Merged
merged 7 commits into from
Nov 17, 2019
Merged

CI: Adding GitHub action to assign issues based on comment #29648

merged 7 commits into from
Nov 17, 2019

Conversation

datapythonista
Copy link
Member

Currently, only maintainers and triagers can assign issues.

This implements a hack, so when any contributor writes the keyword take in an issue, GitHub actions will automatically assign the issue to the commenter.

I think this should be very helpful once people start to assign issues to themselves, since adding the Assigned to nobody filter should let people find issues that nobody is working on. May be in the future we want to implement another action to unassign issues after a period of inactivity, but so far this should be much better than just having people adding comments.

@pandas-dev/pandas-core what do you think?

@datapythonista datapythonista added the CI Continuous Integration label Nov 15, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 17, 2019 via email

@jreback jreback added this to the 1.0 milestone Nov 17, 2019
steps:
- name:
run: |
if [[ "${{ github.event.comment.body }}" == "take" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about take-issue or assign-issue (then in theory could actually specify a username after)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the keyword, I found take the simplest option (thought of assign too, but I think it's easier to make typos, asign, assing...).

I thought about adding a user after it, but we (maintainers/triagers) can already assign issues with GitHub UI. And I don't see regular users wanting to assign to someone else. And note that GitHub limits assignees to people who commented on the issue. That's the "fun" part, creating the comment with the take is what allows the action to assign to the commenter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

@jreback jreback merged commit cb68592 into pandas-dev:master Nov 17, 2019
@jreback
Copy link
Contributor

jreback commented Nov 17, 2019

ok let's try this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants