Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Categorical constructor not idempotent with ext dtype #14191

Closed
wants to merge 2 commits into from

Conversation

chris-b1
Copy link
Contributor

@chris-b1 chris-b1 commented Sep 9, 2016

np.array([1, 2, 3], dtype='int64'),
['a', 'b', 'c'],
pd.period_range('2014-01-01', '2014-01-05'),
pd.date_range('2014-01-01', '2014-01-05'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might throw some NaT and nans in

@jreback
Copy link
Contributor

jreback commented Sep 9, 2016

small comment but otherwise lgtm

@codecov-io
Copy link

Current coverage is 85.24% (diff: 100%)

Merging #14191 into master will decrease coverage by <.01%

@@             master     #14191   diff @@
==========================================
  Files           140        140          
  Lines         50555      50555          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43095      43094     -1   
- Misses         7460       7461     +1   
  Partials          0          0          

Powered by Codecov. Last update 8af6264...4cad147

@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions Categorical Categorical Data Type labels Sep 9, 2016
@jreback jreback added this to the 0.19.0 milestone Sep 9, 2016
@jreback
Copy link
Contributor

jreback commented Sep 9, 2016

thanks!

@jreback jreback closed this in 939a221 Sep 9, 2016
@chris-b1 chris-b1 deleted the cat-ctor branch September 10, 2016 12:37
@jreback jreback mentioned this pull request Sep 28, 2016
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Categorical constructor is not idempotent with datetime with tz
3 participants