DEPS: Drop Python 3.4 support #16303

gfyoung · 2017-05-09T15:06:48Z

Title is self-explanatory.

codecov · 2017-05-09T16:05:53Z

Codecov Report

Merging #16303 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #16303      +/-   ##
==========================================
- Coverage   90.39%   90.37%   -0.02%     
==========================================
  Files         161      161              
  Lines       50863    50863              
==========================================
- Hits        45977    45968       -9     
- Misses       4886     4895       +9

Flag	Coverage Δ
#multiple	`88.16% <ø> (ø)`	⬆️
#single	`40.33% <ø> (-0.11%)`	⬇️

Impacted Files	Coverage Δ
pandas/compat/__init__.py	`61.77% <ø> (ø)`	⬆️
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/core/frame.py	`97.59% <0%> (-0.1%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4eef3...a186ba8. Read the comment docs.

codecov · 2017-05-09T16:06:08Z

Codecov Report

Merging #16303 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #16303      +/-   ##
==========================================
- Coverage   90.38%   90.36%   -0.03%     
==========================================
  Files         161      161              
  Lines       50916    50916              
==========================================
- Hits        46021    46009      -12     
- Misses       4895     4907      +12

Flag	Coverage Δ
#multiple	`88.13% <ø> (-0.01%)`	⬇️
#single	`40.22% <ø> (-0.11%)`	⬇️

Impacted Files	Coverage Δ
pandas/compat/__init__.py	`61.77% <ø> (ø)`	⬆️
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/core/common.py	`90.68% <0%> (-0.35%)`	⬇️
pandas/util/testing.py	`80.56% <0%> (-0.2%)`	⬇️
pandas/core/frame.py	`97.68% <0%> (-0.1%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea0f25...9c33e44. Read the comment docs.

jreback · 2017-05-10T11:06:48Z

so we have a couple of circle ci jobs which test 3.4 move these to 3.6 i think. (they still hit a case which we need to test).

gfyoung · 2017-05-10T14:50:12Z

@jreback : Good catch. Copied and pasted the requirements-3.6* files to requirements-3.6_SLOW* files and also removed 3.4 from the tox.ini file (git diff is not very helpful, hence why I'm explaining my changes here).

gfyoung · 2017-05-10T19:02:18Z

@jreback : Weird locale failure on Circle here. Not sure what is wrong with the test files.

gfyoung · 2017-05-12T00:39:09Z

@jreback : Everything is green here, but I presume you are waiting to merge this until AFTER 0.20.2 is released into the wild (correct me if I'm wrong).

jreback · 2017-05-12T10:25:30Z

@gfyoung no, we can merge things for 0.21.0 now. @jorisvandenbossche had an objection. I actually have no problem with this. yes its not hard to support. But 3.4 is not very well supported by conda anymore, no point in us holding out the torch.

gfyoung · 2017-05-12T15:06:07Z

@jreback : So is this good to go then?

jreback · 2017-05-12T22:58:31Z

ci/requirements-3.6.run

@@ -14,7 +14,7 @@ html5lib
 jinja2
 sqlalchemy
 pymysql
-feather-format
+# feather-format (not available on defaults ATM)


no, the 3.6 run specially uses conda-forge (this is the only run that does this)

So just change the comment?

revert the change
you shouldn't be changing this file
it's for the travis build

Circle broke when i left the file as is. Couldn't install feather.

u need a separate file (and a different job tag)
also ok to just have 3 circle jobs

Ah, okay. That's works. Will do then.

gfyoung · 2017-05-13T18:26:54Z

@jreback : Made the requested changes, and everything is still green. PTAL.

jreback · 2017-05-13T21:32:51Z

circle.yml

@@ -23,9 +23,9 @@ dependencies:
       0)
         sudo apt-get install language-pack-it && ./ci/install_circle.sh JOB="2.7_COMPAT" LOCALE_OVERRIDE="it_IT.UTF-8" ;;
       1)
-         sudo apt-get install language-pack-zh-hans && ./ci/install_circle.sh JOB="3.4_SLOW" LOCALE_OVERRIDE="zh_CN.UTF-8" ;;
+         sudo apt-get install language-pack-zh-hans && ./ci/install_circle.sh JOB="3.6_SLOW" LOCALE_OVERRIDE="zh_CN.UTF-8" ;;


actuall let's name these

3.6_LOCALE_SLOW
3.6_LOCALE

I think it more consistent

Sounds good. Done.

Closes pandas-devgh-15251.

gfyoung · 2017-05-13T23:33:53Z

@jreback : Made the requested changes, and everything is still green. PTAL.

jreback · 2017-05-15T10:22:14Z

ci/requirements-3.6_SLOW.build

@@ -0,0 +1,6 @@
+python=3.6*


seems you added a 3.6_SLOW, pls remove.

Oops. Done.

gfyoung · 2017-05-15T18:55:44Z

@jreback : Made the requested changes, and everything is still green. PTAL.

jreback · 2017-05-16T00:02:15Z

thanks!

* upstream/master: (48 commits) BUG: Categorical comparison with unordered (pandas-dev#16339) ENH: Adding 'protocol' parameter to 'to_pickle'. PERF: improve MultiIndex get_loc performance (pandas-dev#16346) TST: remove pandas-datareader xfail as 0.4.0 works (pandas-dev#16374) TST: followup to pandas-dev#16364, catch errstate warnings (pandas-dev#16373) DOC: new oauth token TST: Add test for clip-na (pandas-dev#16369) ENH: Draft metadata specification doc for Apache Parquet (pandas-dev#16315) MAINT: Add .iml to .gitignore (pandas-dev#16368) BUG/API: Categorical constructor scalar categories (pandas-dev#16340) ENH: Provide dict object for to_dict() pandas-dev#16122 (pandas-dev#16220) PERF: improved clip performance (pandas-dev#16364) DOC: try new token for docs DOC: try with new secure token DOC: add developer section to the docs DEPS: Drop Python 3.4 support (pandas-dev#16303) DOC: remove credential helper DOC: force fetch on build docs DOC: redo dev docs access token DOC: add dataframe construction in merge_asof example (pandas-dev#16348) ...

* DEPS: Drop Python 3.4 support Closes pandas-devgh-15251. * TST: Patch locale failure on Circle

TomAugspurger added this to the 0.21.0 milestone May 9, 2017

jreback added the Dependencies Required and optional dependencies label May 9, 2017

gfyoung force-pushed the python-3.4-drop branch from a186ba8 to a121cb0 Compare May 9, 2017 19:59

gfyoung force-pushed the python-3.4-drop branch from a121cb0 to 36d1cde Compare May 10, 2017 14:48

gfyoung force-pushed the python-3.4-drop branch 2 times, most recently from 78edc13 to 9f9389d Compare May 10, 2017 17:11

gfyoung force-pushed the python-3.4-drop branch 2 times, most recently from c628c2d to 1b3ec7c Compare May 11, 2017 21:21

gfyoung force-pushed the python-3.4-drop branch from 1b3ec7c to 0683201 Compare May 12, 2017 06:44

gfyoung force-pushed the python-3.4-drop branch from 0683201 to c278362 Compare May 12, 2017 22:00

jreback reviewed May 12, 2017

View reviewed changes

gfyoung force-pushed the python-3.4-drop branch from c278362 to 174b2c1 Compare May 13, 2017 16:09

gfyoung force-pushed the python-3.4-drop branch from 174b2c1 to 4c6aab6 Compare May 13, 2017 18:27

jreback reviewed May 13, 2017

View reviewed changes

DEPS: Drop Python 3.4 support

2c5715b

Closes pandas-devgh-15251.

gfyoung force-pushed the python-3.4-drop branch from 4c6aab6 to 964e790 Compare May 13, 2017 21:45

jreback reviewed May 15, 2017

View reviewed changes

TST: Patch locale failure on Circle

9c33e44

gfyoung force-pushed the python-3.4-drop branch from 964e790 to 9c33e44 Compare May 15, 2017 15:30

jreback merged commit 2ba7f5f into pandas-dev:master May 16, 2017

gfyoung deleted the python-3.4-drop branch May 16, 2017 07:15

pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017

DEPS: Drop Python 3.4 support (pandas-dev#16303)

9de6b51

* DEPS: Drop Python 3.4 support Closes pandas-devgh-15251. * TST: Patch locale failure on Circle

stangirala pushed a commit to stangirala/pandas that referenced this pull request Jun 11, 2017

DEPS: Drop Python 3.4 support (pandas-dev#16303)

f278905

* DEPS: Drop Python 3.4 support Closes pandas-devgh-15251. * TST: Patch locale failure on Circle

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DEPS: Drop Python 3.4 support #16303

DEPS: Drop Python 3.4 support #16303

gfyoung commented May 9, 2017

codecov bot commented May 9, 2017 •

edited

Loading

codecov bot commented May 9, 2017 •

edited

Loading

jreback commented May 10, 2017 •

edited

Loading

gfyoung commented May 10, 2017

gfyoung commented May 10, 2017 •

edited

Loading

gfyoung commented May 12, 2017 •

edited

Loading

jreback commented May 12, 2017

gfyoung commented May 12, 2017

jreback May 12, 2017

gfyoung May 12, 2017

jreback May 12, 2017

gfyoung May 12, 2017

jreback May 12, 2017

gfyoung May 13, 2017

gfyoung commented May 13, 2017 •

edited

Loading

jreback May 13, 2017

gfyoung May 13, 2017

gfyoung commented May 13, 2017

jreback May 15, 2017

gfyoung May 15, 2017

gfyoung commented May 15, 2017

jreback commented May 16, 2017

DEPS: Drop Python 3.4 support #16303

DEPS: Drop Python 3.4 support #16303

Conversation

gfyoung commented May 9, 2017

codecov bot commented May 9, 2017 • edited Loading

Codecov Report

codecov bot commented May 9, 2017 • edited Loading

Codecov Report

jreback commented May 10, 2017 • edited Loading

gfyoung commented May 10, 2017

gfyoung commented May 10, 2017 • edited Loading

gfyoung commented May 12, 2017 • edited Loading

jreback commented May 12, 2017

gfyoung commented May 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gfyoung commented May 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gfyoung commented May 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gfyoung commented May 15, 2017

jreback commented May 16, 2017

codecov bot commented May 9, 2017 •

edited

Loading

codecov bot commented May 9, 2017 •

edited

Loading

jreback commented May 10, 2017 •

edited

Loading

gfyoung commented May 10, 2017 •

edited

Loading

gfyoung commented May 12, 2017 •

edited

Loading

gfyoung commented May 13, 2017 •

edited

Loading