CLN: let Index use general concat machinery - remove Index._concat_same_dtype #34198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on the recent changes in the
concat_compat
machinery (to use the_get_common_dtype
protocol for EAs), we can also use this in the Index class.Doing this also makes the
_concat_same_dtype
method unnecessary (as this is handled inconcat_compat
to useEA._concat_same_type
when appropriate)cc @jbrockmendel