Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: let Index use general concat machinery - remove Index._concat_same_dtype #34198

Merged

Conversation

jorisvandenbossche
Copy link
Member

Following up on the recent changes in the concat_compat machinery (to use the _get_common_dtype protocol for EAs), we can also use this in the Index class.

Doing this also makes the _concat_same_dtype method unnecessary (as this is handled in concat_compat to use EA._concat_same_type when appropriate)

cc @jbrockmendel

@jorisvandenbossche jorisvandenbossche added Clean Index Related to the Index class or subclasses labels May 15, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.1 milestone May 15, 2020
@jbrockmendel
Copy link
Member

nice cleanup

@jreback jreback merged commit 63133a4 into pandas-dev:master May 17, 2020
@jreback
Copy link
Contributor

jreback commented May 17, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Index Related to the Index class or subclasses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants