Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: avoid use of to_perioddelta #34539

Merged
merged 5 commits into from
Jun 3, 2020

Conversation

jbrockmendel
Copy link
Member

tslibs is nominally self-contained, but several offsets methods still rely on DatetimeArray/PeriodArray behavior. This is the first of several steps whittling that away.

@jbrockmendel jbrockmendel changed the title REF: return ndarray from to_perioddelta; use it less REF: avoid use of to_perioddelta Jun 3, 2020
@jreback jreback added Clean Timedelta Timedelta data type labels Jun 3, 2020
@jreback jreback added this to the 1.1 milestone Jun 3, 2020
@jreback jreback added the Period Period data type label Jun 3, 2020
@jreback jreback merged commit 639e3db into pandas-dev:master Jun 3, 2020
@jreback
Copy link
Contributor

jreback commented Jun 3, 2020

sure can we completely remove to_perioddelta?

@jbrockmendel
Copy link
Member Author

sure can we completely remove to_perioddelta?

hopefully, but the remaining usages aren't as striaghtforward. xref #34555 moving in that direction.

Veronur pushed a commit to Veronur/pandas that referenced this pull request Jun 17, 2020
correction and test for issue-pandas-dev#34529

made the formating changes

fixing tests on issue-pandas-dev#34529

add whats new entry on issue-pandas-dev#34539
Veronur pushed a commit to Veronur/pandas that referenced this pull request Jun 17, 2020
correction and test for issue-pandas-dev#34529

made the formating changes

fixing tests on issue-pandas-dev#34529

add whats new entry on issue-pandas-dev#34539

add whats new entry correction issue-pandas-dev#34539
Veronur pushed a commit to Veronur/pandas that referenced this pull request Jun 18, 2020
correction and test for issue-pandas-dev#34529

made the formating changes

fixing tests on issue-pandas-dev#34529

add whats new entry on issue-pandas-dev#34539

add whats new entry correction issue-pandas-dev#34539

whats new correction issue-pandas-dev#34539
@jbrockmendel jbrockmendel deleted the ref-perioddelta branch November 20, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Period Period data type Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants