Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.6 support #35214

Merged
merged 68 commits into from
Aug 11, 2020
Merged

Drop Python 3.6 support #35214

merged 68 commits into from
Aug 11, 2020

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Jul 10, 2020 •
edited
Loading

  • closes DEPS: drop 3.6 #34472
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added this to the 1.2 milestone Jul 10, 2020
@jreback jreback added the Dependencies Required and optional dependencies label Jul 10, 2020
jreback
jreback requested changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, we would look to do this post 1.1 release, e.g. target 1.2 (so soonish)

WillAyd
WillAyd reviewed Jul 10, 2020
View reviewed changes
setup.py Show resolved Hide resolved
@fangchenli

This comment has been minimized.

Sign in to view
@jorisvandenbossche jorisvandenbossche changed the title Drop 3.6 Drop Python 3.6 support Jul 11, 2020
@fangchenli fangchenli deleted the drop-3.6 branch August 11, 2020 01:39
jbrockmendel
jbrockmendel reviewed Aug 11, 2020
View reviewed changes
pandas/tests/io/parser/test_common.py
@@ -1151,6 +1152,7 @@ def test_chunks_have_consistent_numerical_type(all_parsers):
assert result.a.dtype == float


@pytest.mark.skip("unreliable test #35214")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. should this be xfail?
  2. i think the solution will end up involving using td.check_file_leaks in a lot of places. Is there a non-verbose way to run it once at the module level?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Yes, it should be xfail. I'll submit a PR to fix this.
  2. Haven't thought about this. Might need some discussion.

@simonjayhawkins simonjayhawkins mentioned this pull request Aug 13, 2020
Merged
simonjayhawkins added a commit to simonjayhawkins/pandas that referenced this pull request Aug 14, 2020
@simonjayhawkins
CI: doctest failure for read_hdf on 1.1.x (fixed in pandas-dev#35214 …
b4da38b 
…on master)
@simonjayhawkins simonjayhawkins mentioned this pull request Aug 14, 2020
Merged
simonjayhawkins added a commit that referenced this pull request Aug 14, 2020
@simonjayhawkins
CI: doctest failure for read_hdf on 1.1.x (fixed in #35214 on master) (…
f15a60a 
…#35718)
@fangchenli fangchenli mentioned this pull request Aug 14, 2020
Closed
@alimcmaster1 alimcmaster1 mentioned this pull request Aug 20, 2020
Merged
@bhilbert4 bhilbert4 mentioned this pull request Sep 8, 2020
Closed
@TomAugspurger TomAugspurger mentioned this pull request Sep 22, 2020
Open
This was referenced Sep 23, 2020
Merged
Merged
This was referenced Sep 23, 2020
Open
Open
@konstin konstin mentioned this pull request Sep 25, 2020
Closed
@ivanovmg ivanovmg mentioned this pull request Sep 27, 2020
Merged
@weiji14 weiji14 mentioned this pull request Oct 8, 2020
Closed
@tswast tswast mentioned this pull request Nov 6, 2020
Closed
@weiji14 weiji14 mentioned this pull request Nov 14, 2020
Closed
simonjayhawkins added a commit to simonjayhawkins/pandas that referenced this pull request Nov 26, 2020
@simonjayhawkins
xfail changes from pandas-dev#35214 for test_apply
66ee6f3
shlomiku added a commit to alpacahq/alpaca-trade-api-python that referenced this pull request Dec 8, 2020
@shlomiku
pandas 1.2.0 supports Python 3.7.1 and higher (GH35214).
71d825b 
pandas-dev/pandas#35214
This was referenced Jan 8, 2021
Closed
Closed
@desilinguist desilinguist mentioned this pull request Jan 12, 2021
Closed
@grahamgower grahamgower mentioned this pull request Jan 23, 2021
Merged
@chezou chezou mentioned this pull request Feb 2, 2021
Closed
@xiki-tempula xiki-tempula mentioned this pull request Jun 11, 2021
Merged
@lucasjamar lucasjamar mentioned this pull request Jul 5, 2021
Closed
6 tasks
@weiji14 weiji14 mentioned this pull request Mar 27, 2022
Merged
@jameslamb jameslamb mentioned this pull request Mar 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimcmaster1 alimcmaster1 alimcmaster1 left review comments

@jbrockmendel jbrockmendel jbrockmendel left review comments

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

@WillAyd WillAyd WillAyd left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Dependencies Required and optional dependencies
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

DEPS: drop 3.6
9 participants
@fangchenli @simonjayhawkins @jreback @pep8speaks @TomAugspurger @WillAyd @jorisvandenbossche @jbrockmendel @alimcmaster1