Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Added test for upcasting to object when concatinating on categorical indexes with non-identical categories #42278

Merged
merged 10 commits into from
Jul 1, 2021

Conversation

P-Tillmann
Copy link
Contributor

This PR simple adds a test for upcasting to object when concatinating on categorical indexes with non-identical categories.

@P-Tillmann P-Tillmann changed the title [TST] Added test for upcasting to object when concatinating on categorical indexes with non-identical categories TST: Added test for upcasting to object when concatinating on categorical indexes with non-identical categories Jun 28, 2021
@P-Tillmann
Copy link
Contributor Author

One of the azure pipelines failed, because it timed out after 60 min. Is this something that just happens sometimes or does it indicate there is something wrong with the PR?

@jreback jreback added Categorical Categorical Data Type Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite labels Jul 1, 2021
@jreback jreback added this to the 1.4 milestone Jul 1, 2021
@jreback jreback merged commit 0135b79 into pandas-dev:master Jul 1, 2021
@jreback
Copy link
Contributor

jreback commented Jul 1, 2021

thanks @P-Tillmann very nice!

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concat on non-identical categories in categorical indexes raises TypeError
2 participants