Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: Try strip-all instead of strip-debug #51931

Merged
merged 1 commit into from
Mar 13, 2023
Merged

BLD: Try strip-all instead of strip-debug #51931

merged 1 commit into from
Mar 13, 2023

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@lithomas1 lithomas1 added the Build Library building on various platforms label Mar 13, 2023
@lithomas1 lithomas1 marked this pull request as ready for review March 13, 2023 17:12
@lithomas1
Copy link
Member Author

Seems to save about 0.5 MB, looking at the artifacts page.

@jameslamb
Can you try the wheel inside the zip file here https://github.com/pandas-dev/pandas/suites/11527579227/artifacts/596379601 and let me know if you still see debug symbols?

@jameslamb
Copy link
Contributor

Amazing, thanks for looking into it so quickly!

I just pulled the wheel from that link you shared (pandas-2.1.0.dev0+189.gd3f4d638df-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl) and can confirm I don't see any debug symbols (using several different approaches for finding them) 🎉

@lithomas1 lithomas1 added this to the 2.0 milestone Mar 13, 2023
@lithomas1 lithomas1 merged commit 7ab6f8b into pandas-dev:main Mar 13, 2023
@lithomas1 lithomas1 deleted the strip-more branch March 13, 2023 20:02
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 13, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 13, 2023
@lithomas1 @meeseeksmachine
Backport PR pandas-dev#51931: BLD: Try strip-all instead of strip-debug
fba6063
phofl pushed a commit that referenced this pull request Mar 13, 2023
@meeseeksmachine @lithomas1
Backport PR #51931 on branch 2.0.x (BLD: Try strip-all instead of str…
bd23fff 
…ip-debug) (#51938)

Backport PR #51931: BLD: Try strip-all instead of strip-debug

Co-authored-by: Thomas Li <[email protected]>
@jameslamb jameslamb mentioned this pull request Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lithomas1 @jameslamb @WillAyd