Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release the gil in take for axis=1 #57454

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Release the gil in take for axis=1 #57454

merged 1 commit into from
Feb 16, 2024

Conversation

phofl
Copy link
Member

@phofl phofl commented Feb 16, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

We missed this when we took care of axis=0 in Basel

@phofl phofl requested a review from WillAyd as a code owner February 16, 2024 14:02
@WillAyd WillAyd merged commit 0863b22 into pandas-dev:main Feb 16, 2024
47 checks passed
@WillAyd
Copy link
Member

WillAyd commented Feb 16, 2024

Thanks @phofl

@phofl
Copy link
Member Author

phofl commented Feb 18, 2024

@meeseeksdev backport 2.2.x

@phofl
Copy link
Member Author

phofl commented Feb 18, 2024

I'd like to backport this, it should be very very minor but makes debugging performance shit in dask quite cumbersome (cc @mroeschke for visibility)

@phofl phofl deleted the gil_take branch February 18, 2024 11:44
phofl added a commit that referenced this pull request Feb 18, 2024
…1) (#57484)

Backport PR #57454: Release the gil in take for axis=1

Co-authored-by: Patrick Hoefler <[email protected]>
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants