Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: fix SA01, ES01 for pandas.Timedelta.to_timedelta64 #59860

Merged

Conversation

tuhinsharma121
Copy link
Contributor

fixes

pandas.Timedelta.to_timedelta64 SA01, ES01

@tuhinsharma121 tuhinsharma121 marked this pull request as ready for review September 22, 2024 06:50
@@ -1411,6 +1411,18 @@ cdef class _Timedelta(timedelta):
"""
Return a numpy.timedelta64 object with 'ns' precision.

Since NumPy uses `timedelta64` objects for its time operations, converting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Since NumPy uses `timedelta64` objects for its time operations, converting
Since NumPy uses ``timedelta64`` objects for its time operations, converting

And could you use double backticks consistently here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. its regarding sphinx documentation I believe. Learnt about it couple of days back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@mroeschke mroeschke added the Docs label Sep 25, 2024
@mroeschke mroeschke added this to the 3.0 milestone Sep 25, 2024
@mroeschke mroeschke merged commit efbc296 into pandas-dev:main Sep 25, 2024
50 of 51 checks passed
@mroeschke
Copy link
Member

Thanks @tuhinsharma121

@tuhinsharma121 tuhinsharma121 deleted the pandas.Timedelta.to_timedelta64 branch November 1, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants