BUG: Raise TypeError when subracting DateTimeArray and other date types #59901
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhshadrach - can you verify if my implementation here is correct? I'm not sure of this. A bit of guidance could be useful. Thanks |
rhshadrach
requested changes
Sep 27, 2024
rhshadrach
reviewed
Sep 27, 2024
pandas/core/arrays/datetimelike.py
Outdated
| @@ -18,6 +18,7 @@ | |||
| import warnings | |||
|
|
|||
| import numpy as np | |||
| import pandas | |||
There was a problem hiding this comment.
We shouldn't be importing pandas at the top of a module like this - it will cause import cycles. Search for where DatetimeArray is imported in other parts of the code and follow those examples.
There was a problem hiding this comment.
In general, search what you want to import and see how other code does it.
grep --include \*.py -nre ".*import.*DatetimeArray"
pandas/core/ops/array_ops.py:535: from pandas.core.arrays import DatetimeArray
pandas/core/dtypes/dtypes.py:858: from pandas.core.arrays import DatetimeArray
pandas/core/dtypes/dtypes.py:944: from pandas.core.arrays import DatetimeArray
pandas/core/dtypes/astype.py:105: from pandas.core.arrays import DatetimeArray
There was a problem hiding this comment.
Thanks @rhshadrach, I have removed this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.