Don't delete *.pyc files from the image #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panel and Xarray-Leaflet are heavy enough imports that without .pyc files, they sometimes together take as much as 15s to import?! This causes jupyterhub to fail startup in some cases. The longer term fix is in panel and xarray-leaflet ( see holoviz/panel#4271, xarray-contrib/xarray_leaflet#79). In the meantime, leaving the .pyc files in place doesn't increase the image size by much, but makes startup definitely much faster! Ref 2i2c-org/infrastructure#2047
|
|
5 tasks
scottyhq
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Amazing analysis in the linked issue @yuvipanda this seems like it was a tricky one to track down! I've always been a bit reluctant about removing files to save space in the docker image (why not just remove them from the package if they aren't necessary?)
This illustrates there are two related performance optimizations to track:
- container size to reduce time pulling and storing images but which impacts...
- the container start-up time in jupyterhub!
|
Thanks @scottyhq! Yes, the performance of the pull is the trade-off here! I think .pyc are small enough though, so is probably fine - although let’s see how big the image gets when it is built and pushed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panel and Xarray-Leaflet are heavy enough imports that without .pyc files, they sometimes together take as much as 15s to import?! This causes jupyterhub to fail startup in some cases.
The longer term fix is in panel and xarray-leaflet ( see holoviz/panel#4271,
xarray-contrib/xarray_leaflet#79).
In the meantime, leaving the .pyc files in place doesn't increase the image size by much, but makes startup definitely much faster!
Ref 2i2c-org/infrastructure#2047