-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ocean packages to pangeo-notebook #83
Add ocean packages to pangeo-notebook #83
Conversation
pangeo-notebook/environment.yml
Outdated
- zarr | ||
- pip: | ||
- fastjmd95 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As soon as conda-forge/staged-recipes#11980 is merged, we can install this from conda.
/condalock ☝️ remember you need this comment to update lock files prior to building. fine by me to add these packages. |
locking environment failed (https://github.com/pangeo-data/pangeo-docker-images/runs/797223398?check_suite_focus=true) because pip isn't supported by conda-lock (mariusvniekerk/conda-lock#4). We got around this in the ml-notebook image by also including a sidecar requirements.txt. https://github.com/pangeo-data/pangeo-docker-images/blob/master/ml-notebook/requirements.txt The base-image Dockerfile runs a pangeo-docker-images/base-image/Dockerfile Line 117 in d4b3c1e
|
/condalock |
bd11faa
to
30c2ee7
Compare
/condalock |
@scottyhq fixed the merge conflicts (I was behind when I made my branch). |
xref #28