Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ocean packages to pangeo-notebook #83

Merged
merged 2 commits into from
Jun 23, 2020

Conversation

TomAugspurger
Copy link
Member

xref #28

@TomAugspurger
Copy link
Member Author

cc @scottyhq & @jhamman.

- zarr
- pip:
- fastjmd95
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon as conda-forge/staged-recipes#11980 is merged, we can install this from conda.

@scottyhq
Copy link
Member

/condalock

☝️ remember you need this comment to update lock files prior to building. fine by me to add these packages.

@scottyhq
Copy link
Member

locking environment failed (https://github.com/pangeo-data/pangeo-docker-images/runs/797223398?check_suite_focus=true) because pip isn't supported by conda-lock (mariusvniekerk/conda-lock#4).

We got around this in the ml-notebook image by also including a sidecar requirements.txt. https://github.com/pangeo-data/pangeo-docker-images/blob/master/ml-notebook/requirements.txt

The base-image Dockerfile runs a pip install command after conda create:

${NB_PYTHON_PREFIX}/bin/pip install --no-cache-dir -r requirements.txt \

@scottyhq
Copy link
Member

/condalock

@TomAugspurger
Copy link
Member Author

/condalock

@TomAugspurger
Copy link
Member Author

@scottyhq fixed the merge conflicts (I was behind when I made my branch).

@TomAugspurger TomAugspurger merged commit b261b3e into pangeo-data:master Jun 23, 2020
@TomAugspurger TomAugspurger deleted the ocean-packages branch June 23, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants