-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define contribution process #71
Conversation
@norlandrhagen, at yesterday's Pangeo Forge Coordination Meeting you mentioned that you and @jhamman may have some bandwidth to contribute to this PR. If that ends up being the case, just wanted to point you to a few resources, to avoid duplication of efforts. First, I've just added https://github.com/pangeo-forge/flow-charts which provides as a place to collaborate on the graphical portion of this. The charts there are written in GraphViz (which is actually surprisingly great!) but if you don't want to wade into that world, feel free to open PRs against that repo with images (hand drawings, Google Slides, etc.), and I can translate them into GraphViz. (This could be for edits to existing charts, or for requesting new ones be added.) Second, just a reminder that we previously chatted about some of the programmatic aspects of local recipe testing, here: pangeo-forge/staged-recipes#68 (comment) Finally, the actual changes in the text of this PR probably needs to be merged with Let me know if there's anything else I can help out with. |
Hey there @cisaacstern, I have a draft for some additions to |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I just You can now add proposed changes to |
d52c47c
to
4c2c0b5
Compare
@norlandrhagen, this is now good to go as described in #71 (comment). The brief blip (about which you'll likely have received a notification from me) was that I needed to, as you'd correctly pointed out to begin with 😄 , rebase this branch, not merge it. Looking forward to your contributions. |
Awesome thanks! I'll add what I have so far. There are definitely a lot of sections where I could use some input/feedback. |
It looks like we can now close this, since it will be superseded by #206? |
inital additions to docs/intro_tutorial.md
Merging so we can get something up on this page. We can iterate further via future PRs. |
As noted by @ciaranevans in pangeo-forge/roadmap#9, our docs on contributing a recipe are now obsolete. This PR gets started on updating that page. Before we can really write that, we need to answer a few questions.