Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conceal to double and tripple equal #1155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nicanordlc
Copy link

@nicanordlc nicanordlc commented Jan 18, 2019

Fixes: #1154

Example code

Not the best code example I guess but here you go... 😅

// foo.js

const null = null;

function a() {
  return 'b';
}

1 == 1
( 1 == 1 )

// vvv Eye focus

const foo = _ => {
  if (1 == 1) {
    return 1;
  } else if ( "a" === "a" ) {
    return "a";
  } else {
    return "¯\\_(ツ)_/¯"
  }
  return false;
}

// ^^^ Eye focus

class obj {
  constructor() {
    super()
  }
}

With conceal

// foo.js

const null = ø;

function a() {
   'b';
}

1 == 1
( 1 == 1 )

// vvv Eye focus

const foo = 🞅  {
  if (1  1) {
     1;
  } else if ( "a"  "a" ) {
     "a";
  } else {
     "¯\\_(ツ)_/¯"
  }
   false;
}

// ^^^ Eye focus

class obj {
  constructor() {
    Ω()
  }
}

I will be updating the preview as I make significant changes.

Anyone feel free to point my 🚢 to the right direction 😬

* Add changes to `README.md`
@nicanordlc
Copy link
Author

@amadeus I think this is ready to check. ( :

Can you check this up, or can you tell me who else can approve/check this ? 👋

@nicanordlc nicanordlc changed the title Add conceal to double and tripple equal [WIP] Add conceal to double and tripple equal Jan 22, 2019
@@ -231,7 +233,7 @@ if exists("javascript_plugin_flow")
endif

syntax cluster jsExpression contains=jsBracket,jsParen,jsObject,jsTernaryIf,jsTaggedTemplate,jsTemplateString,jsString,jsRegexpString,jsNumber,jsFloat,jsOperator,jsOperatorKeyword,jsBooleanTrue,jsBooleanFalse,jsNull,jsFunction,jsArrowFunction,jsGlobalObjects,jsExceptions,jsFutureKeys,jsDomErrNo,jsDomNodeConsts,jsHtmlEvents,jsFuncCall,jsUndefined,jsNan,jsPrototype,jsBuiltins,jsNoise,jsClassDefinition,jsArrowFunction,jsArrowFuncArgs,jsParensError,jsComment,jsArguments,jsThis,jsSuper,jsDo,jsForAwait,jsAsyncKeyword,jsStatement,jsDot
syntax cluster jsAll contains=@jsExpression,jsStorageClass,jsConditional,jsRepeat,jsReturn,jsException,jsTry,jsNoise,jsBlockLabel
syntax cluster jsAll contains=@jsExpression,jsStorageClass,jsConditional,jsRepeat,jsReturn,jsException,jsTry,jsNoise,jsBlockLabel,jsDoubleEqual,jsTripleEqual
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should actually be added to jsExpression above, not all

@bradwood
Copy link

README.md update also please 🙏

@bradwood
Copy link

bradwood commented Sep 1, 2021

any movement on this PR?

Comment on lines -71 to +84
let g:javascript_conceal_function = "ƒ"
let g:javascript_conceal_null = "ø"
let g:javascript_conceal_this = "@"
let g:javascript_conceal_return = "⇚"
let g:javascript_conceal_undefined = "¿"
let g:javascript_conceal_NaN = "ℕ"
let g:javascript_conceal_prototype = "¶"
let g:javascript_conceal_static = "•"
let g:javascript_conceal_super = "Ω"
let g:javascript_conceal_arrow_function = "⇒"
let g:javascript_conceal_noarg_arrow_function = "🞅"
let g:javascript_conceal_function = "ƒ"
let g:javascript_conceal_null = "ø"
let g:javascript_conceal_this = "@"
let g:javascript_conceal_return = "⇚"
let g:javascript_conceal_undefined = "¿"
let g:javascript_conceal_NaN = "ℕ"
let g:javascript_conceal_prototype = "¶"
let g:javascript_conceal_static = "•"
let g:javascript_conceal_super = "Ω"
let g:javascript_conceal_arrow_function = "⇒"
let g:javascript_conceal_noarg_arrow_function = "🞅"
let g:javascript_conceal_underscore_arrow_function = "🞅"
let g:javascript_conceal_double_equal = "≈"
let g:javascript_conceal_triple_equal = "≡"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bradwood , which part of the README.md needs to be updated ?

@amadeus
Copy link
Collaborator

amadeus commented Sep 9, 2021

Also there was some changes I requested that would need to happen before this can get merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no setting for concealing tripple equals or tripple not equals
3 participants