Iopz 2276 update create k8s chained sessions script #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chornbec
commented
Mar 28, 2024
| parent_role_name=$2 | ||
| iam_role_scope=$3 | ||
| persona_name=$4 | ||
| service_name=$2 |
There was a problem hiding this comment.
This is yet another ordered arg, but I figured we don't care about adding another arg since this function is called within the script at the bottom.
jordannb
suggested changes
Mar 28, 2024
create-chained-sessions.sh
Outdated
| @@ -15,15 +15,16 @@ declare REGION='us-east-1' | |||
| # Args: | |||
| # 1: name of environment ("playground", "staging", etc.) | |||
| # 2: sso role name to use for the parent session | |||
| # 3: scope of the IAM role ("panorama" or "eks"). | |||
| # 3: scope of the IAM role ("panorama" or "eks" or "rds"). | |||
There was a problem hiding this comment.
service_name arg is missing up here and numbers are wrong now
jordannb
approved these changes
Mar 28, 2024
This change updates and renames the create-k8s-chained-sessions.sh script to create-chained-sessions.sh after including chained sessions that relate to the DB AWS accounts. These new chained sessions will be used for the new start-db-bastion command, which starts SSM sessions using these new leapp sessions to connect to Bastion hosts in the DB AWS accounts.
chornbec
force-pushed
the
IOPZ-2276-update-create-k8s-chained-sessions-script
branch
from
51e32db
to
121f4d1
Compare
chornbec
deleted the
IOPZ-2276-update-create-k8s-chained-sessions-script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates and renames the create-k8s-chained-sessions.sh script to create-chained-sessions.sh after including chained sessions that relate to the DB AWS accounts. These new chained sessions will be used for the new start-db-bastion command, which starts SSM sessions using these new leapp sessions to connect to Bastion hosts in the DB AWS accounts.
This script was tested by running it in playground and playground-2 after I applied TF changes to the IAM roles from this PR