Add constant to set default cache expire #263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @jimvandervoort ! For clarity, can we call the constant |
jimvandervoort
force-pushed
the
master
branch
from
7118539
to
a466ccd
Compare
|
@danielbachhuber yeah that's better. Changed to |
|
Thanks @jimvandervoort . Landing this in #264 |
|
Just tagged v0.8.1 and released to WordPress.org. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
WP_REDIS_EXPIRE_SECONDSconstant to customise default expire. I added this because on our Redis instance keeps growing with some plugins not setting sensible expire times. Setting a (long) default expire time allows us to work around this issue.