Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGS-5623] Set missing_redis_message if Redis service is not connected #391

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

jspellman814
Copy link

This message currently lives in our mu-plugin, but for folks using WP Redis outside of Pantheon or on a custom upstream, and error is encountered as noted in #377.

@jspellman814 jspellman814 requested a review from a team as a code owner March 6, 2023 22:11
@jspellman814 jspellman814 marked this pull request as draft March 6, 2023 22:11
@jspellman814 jspellman814 marked this pull request as ready for review March 6, 2023 22:22
wp-redis.php Outdated Show resolved Hide resolved
Copy link
Contributor

@jazzsequence jazzsequence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs internationalization

@jspellman814 jspellman814 requested review from a team and jazzsequence March 7, 2023 20:51
Copy link
Contributor

@jazzsequence jazzsequence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically, if we actually had language files and translations, I would use esc_html__ rather than just __, because there's no guarantee that those translations don't include malicious code. But since we don't, that's not a blocker and this is fine.

@jazzsequence jazzsequence merged commit 78fb2a4 into develop Mar 7, 2023
@jazzsequence jazzsequence deleted the bugs-5623 branch March 7, 2023 21:19
jspellman814 pushed a commit that referenced this pull request Mar 7, 2023
…ed (#391)

* Set missing_redis_message if Redis is not connected

* i18n
jspellman814 pushed a commit that referenced this pull request Mar 7, 2023
* [BUGS-5623] Set missing_redis_message if Redis service is not connected (#391)

* Set missing_redis_message if Redis is not connected

* Release 1.3.4
jazzsequence added a commit that referenced this pull request Apr 6, 2023
* [CMS-1033] Add GH action for deployments to wp.org (#368)

* Make dependabot target develop branch (#376)

* Declare wp_cache_supports function and support features (#378)

* Fix broken wp_cache_supports() (#382)

* Update images for lint and test-behat jobs

* Bump yoast/phpunit-polyfills from 1.0.3 to 1.0.4

* Bump dealerdirect/phpcodesniffer-composer-installer from 0.7.2 to 1.0.0

Bumps [dealerdirect/phpcodesniffer-composer-installer](https://github.com/Dealerdirect/phpcodesniffer-composer-installer) from 0.7.2 to 1.0.0.
- [Release notes](https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases)
- [Changelog](https://github.com/PHPCSStandards/composer-installer/blob/main/.github_changelog_generator)
- [Commits](PHPCSStandards/composer-installer@v0.7.2...v1.0.0)

---
updated-dependencies:
- dependency-name: dealerdirect/phpcodesniffer-composer-installer
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump grunt from 1.5.2 to 1.6.1 (#386)

* [CMSP-223] WP Redis housekeeping (#387)

* [CMS-1033] Release 1.3.0 (#371)

* [BUGS-5583] Release 1.3.1 (#379)

* Release 1.3.2 (#383)

* add spdy-compatible license version

* remove reference to package.json

---------

Co-authored-by: John Spellman <[email protected]>

* [CMSP-72] PHP 8.2 compatibility (#388)

* [BUGS-5623] Set missing_redis_message if Redis service is not connected (#391)

* Set missing_redis_message if Redis is not connected

* i18n

* Bump yoast/phpunit-polyfills from 1.0.4 to 1.0.5 (#394)

Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases)
- [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/2.x/CHANGELOG.md)
- [Commits](Yoast/PHPUnit-Polyfills@1.0.4...1.0.5)

---
updated-dependencies:
- dependency-name: yoast/phpunit-polyfills
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* version bump

* update changelogs

* add chris and john to contributors

* Add cms-platform to CODEOWNERS file (#396)

* update date

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: John Spellman <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants