Inaccurate "remote cache time saved" total #15080
Comments
|
Unfortunately I don't repro this locally with |
stuhood
added a commit
that referenced
this issue
Apr 11, 2022
…e children (#15088) #15080 was caused by two factors: 1. #14541 made counters global via a new API, and attached them (as deprecated) to "the root workunit" (with "has no parent id" as the heuristic that something was the root workunit). 2. #14856 moved to calculating the parent(s) of a node based on a running graph of workunits (to allow #14680 to eventually add multiple parents), which meant that when nodes completed out of order, we might not have any parents for them. Together: this meant that when workunits completed asynchronously, we might not have parents for them, and because of the deprecation, we would attach the counters to multiple workunits. A consumer which was aggregating the counters would end up with an inaccurate total. Fixes #15080.
stuhood
added a commit
to stuhood/pants
that referenced
this issue
Apr 11, 2022
…e children (pantsbuild#15088) 1. pantsbuild#14541 made counters global via a new API, and attached them (as deprecated) to "the root workunit" (with "has no parent id" as the heuristic that something was the root workunit). 2. pantsbuild#14856 moved to calculating the parent(s) of a node based on a running graph of workunits (to allow pantsbuild#14680 to eventually add multiple parents), which meant that when nodes completed out of order, we might not have any parents for them. Together: this meant that when workunits completed asynchronously, we might not have parents for them, and because of the deprecation, we would attach the counters to multiple workunits. A consumer which was aggregating the counters would end up with an inaccurate total. Fixes pantsbuild#15080.
stuhood
added a commit
that referenced
this issue
Apr 11, 2022
…e children (cherrypick of #15088) (#15103) #15080 was caused by two factors: 1. #14541 made counters global via a new API, and attached them (as deprecated) to "the root workunit" (with "has no parent id" as the heuristic that something was the root workunit). 2. #14856 moved to calculating the parent(s) of a node based on a running graph of workunits (to allow #14680 to eventually add multiple parents), which meant that when nodes completed out of order, we might not have any parents for them. Together: this meant that when workunits completed asynchronously, we might not have parents for them, and because of the deprecation, we would attach the counters to multiple workunits. A consumer which was aggregating the counters would end up with an inaccurate total. Fixes #15080.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Recent builds of the
2.11.xbranch have inaccurate "remote cache time saved" totals in Pants' recorded metrics, although it looks like the histogram is accurate.The text was updated successfully, but these errors were encountered: