Prepare 2.0.0rc0 #10943
Merged
Prepare 2.0.0rc0 #10943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
Eric-Arellano
requested review from
jsirois,
benjyw,
cosmicexplorer and
gshuflin
Eric-Arellano
commented
Oct 11, 2020
There was a problem hiding this comment.
Reviewers, as decided in #10916, we are no longer putting internal only changes in the changelog. Please check the PR description if you believe any of those changes were misclassified.
| * Send SIGTERM to child processes upon SIGINT (#10930) | ||
| `PR #10930 <https://github.com/pantsbuild/pants/pull/10930>`_ | ||
|
|
||
| * Fix Python 3.8 syntax not working with dependency inference (#10907) |
There was a problem hiding this comment.
@cosmicexplorer I reworded this to emphasize the "So what?" to the user, rather than the "how it's done"
There was a problem hiding this comment.
Thanks!! Will keep in mind for the future.
cosmicexplorer
approved these changes
Oct 12, 2020
| * Send SIGTERM to child processes upon SIGINT (#10930) | ||
| `PR #10930 <https://github.com/pantsbuild/pants/pull/10930>`_ | ||
|
|
||
| * Fix Python 3.8 syntax not working with dependency inference (#10907) |
There was a problem hiding this comment.
Thanks!! Will keep in mind for the future.
| Documentation | ||
| ~~~~~~~~~~~~~ | ||
|
|
||
| * Differentiate between User API vs. Plugin API changes in changelog (#10916) |
| * Add MyPy Protobuf plugin support (#10931) | ||
| `PR #10931 <https://github.com/pantsbuild/pants/pull/10931>`_ | ||
|
|
||
| * Add `output_path` field to `python_binary`, `python_awslambda`, and `archive` (#10899) |
jsirois
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal only changes left off from the changelog:
Use cpython types in Rust functions that manipulate python objects (Use cpython types in Rust functions that manipulate python objects #10942)
PR #10942 <https://github.com/pantsbuild/pants/pull/10942>_update libz-sys version to fix macOS compile error (update libz-sys version to fix macOS compile error #10941)
PR #10941 <https://github.com/pantsbuild/pants/pull/10941>_Upgrade to Rust stable 1.47.0. (Upgrade to Rust stable 1.47.0. #10933)
PR #10933 <https://github.com/pantsbuild/pants/pull/10933>_Finish CreateDigest Directory cleanup. (Finish CreateDigest Directory cleanup. #10935)
PR #10935 <https://github.com/pantsbuild/pants/pull/10935>_Hotfix broken import from merge conflict (Hotfix broken import from merge conflict #10934)
PR #10934 <https://github.com/pantsbuild/pants/pull/10934>_Revert "Port nailgun client to rust (Port nailgun client to rust #10865)" (Revert "Port nailgun client to rust (#10865)" #10929)
PR #10929 <https://github.com/pantsbuild/pants/pull/10929>_An ExternalTool for downloading the grpc_python_plugin. (An ExternalTool for downloading the grpc_python_plugin. #10927)
PR #10927 <https://github.com/pantsbuild/pants/pull/10927>_Port nailgun client to rust (Port nailgun client to rust #10865)
PR #10865 <https://github.com/pantsbuild/pants/pull/10865>_print stacktraces during import errors (print stacktraces during import errors #10906)
PR #10906 <https://github.com/pantsbuild/pants/pull/10906>_fs.Digest is declared in Rust (fs.Digest is declared in Rust #10905)
PR #10905 <https://github.com/pantsbuild/pants/pull/10905>_add requests_ca_bundle to settable_env_vars (add requests_ca_bundle to settable_env_vars #10909)
PR #10909 <https://github.com/pantsbuild/pants/pull/10909>_[ci skip-rust]