Wait for all Sessions during pantsd shutdown (cherrypick of #11929) #11934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #11618, when
pantsd
intentionally exits due to low memory, a few types of work can be cut short:pantsd
exits.This change adds orderly-shutdown mechanisms to the
Scheduler
/Core
to join all ongoingSessions
(including the SWH), and improves tests to ensure that the SWH is waited for.Additionally, in the last commit, added purging of the
pantsd
metadata as soon as we decide to restart, which should reduce (but probably not eliminate) the incidence of item 1. from #11618. Work for #11831 will likely further harden this path.[ci skip-build-wheels]