Fix poetry_requirements: ignore internal projects. #12280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move to parse state storage from ParseContext to parser where it belongs. This cleans up the conceptual model a bit and allows for typing without untoward dependencies. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Previously dependencies with paths were assumed to be non-Pants controlled projects and the resulting requirements were not generate with absolute file URLs. Fix both issues by assuming all paths that point to directories inside the build root are Pants controlled projects and treating the rest as absolute file URL requirements. Fixes pantsbuild#12272 [ci skip-rust] [ci skip-build-wheels]
|
Obviously |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
approved these changes
Jul 6, 2021
Comment on lines
+143
to
+154
| """Determine if the given path represents a non-Pants controlled project. | ||
|
|
||
| If the path points to a file, it's assumed the file is a distribution ( a wheel or sdist) | ||
| and the absolute path of that file is returned. | ||
|
|
||
| If the path points to a directory and that directory is outside of the build root, it's | ||
| assumed the directory is the root of a buildable Python project (i.e.: it contains a | ||
| pyproject.toml or setup.py) and the absolute path of the project is returned. | ||
|
|
||
| Otherwise, `None` is returned since the directory lies inside the build root and is assumed | ||
| to be a Pants controlled project. | ||
| """ |
There was a problem hiding this comment.
The resolution of filesystem paths makes this more susceptible to #7022, but I don't see a good way to resolve that without resolving the underlying issue.
Eric-Arellano
approved these changes
Jul 7, 2021
…omit-local-project-dependencies
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Jul 7, 2021
Previously dependencies with paths were assumed to be non-Pants controlled projects and the resulting requirements were not generated with absolute file URLs. Fix both issues by assuming all paths that point to directories inside the build root are Pants controlled projects and treating the rest as absolute file URL requirements. Fixes pantsbuild#12272 [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously dependencies with paths were assumed to be non-Pants
controlled projects and the resulting requirements were not generated
with absolute file URLs. Fix both issues by assuming all paths that
point to directories inside the build root are Pants controlled
projects and treating the rest as absolute file URL requirements.
Fixes #12272
[ci skip-rust]
[ci skip-build-wheels]