-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render dynamic UI with prodash
#13481
Conversation
This is a draft both because there are a few more issues to nail down (Byron/prodash#9 and Byron/prodash#10), and also because I think that we'll want to see whether we can actually implement some of #11965 before landing this. There are likely also styling changes to be made (light blue is odd, and folks might miss the spinner!). |
7e17fac
to
3f445d1
Compare
Hey @stuhood what would it take to get this in Pants under some experimental flag? I'm thinking maybe
|
Landing this as experimental would require Byron/prodash#9 landing at a minimum (although for an experimental implementation, I suppose that we could land while using the fork). The largest question is really: does this seem like an improvement for you? Have you been able to try it out and see what you think of the experience of using it? Or will getting that experience require landing it first? |
Last time I used it I remember it being much improved. I can try getting some recordings to compare tomorrow. |
3f445d1
to
5fa750c
Compare
[ci skip-build-wheels]
[ci skip-build-wheels]
5fa750c
to
f872a6f
Compare
Thanks: that would be helpful. I've rebased it. |
(Sharing videos in Slack) |
Adapts #13481 to hide it behind the `--dynamic-ui-renderer=experimental-prodash` flag until it can be stabilized and become the default.
Switches to rendering the
--dynamic-ui
withprodash
. Althoughprodash
has fewer users thanindicatif
, the documentation and internals are very solid, and the project maintainer is highly responsive.prodash
's conceptual model is also a much closer fit for our workunits: its core data model is a tree, which naturally allows for rendering workunit hierarchy, and dynamically adding and removing tasks.This change would resolve #13367 by adjusting the number of swimlanes dynamically. But it would also pave a clear path to #11965 to both render task progress via gauges (to show e.g. download progress, or the expected runtime of processes), and potentially by rendering either a child workunit, or the last line of output for long-running tasks as a child of a task.