Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate [validate].detail_level in favor of [sourcefile-validation].detail_level #14103

Merged

Conversation

Eric-Arellano
Copy link
Contributor

Prework for #14102. The GoalSubsystem will be going away so the option should live on the relevant subsystem instead.

I'm not sure if sourcefile-validation is the best options scope for #14102, but I'm not sure what else we would call it.

[ci skip-rust]
[ci skip-build-wheels]

…on].detail_level`

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@Eric-Arellano Eric-Arellano merged commit 1027041 into pantsbuild:main Jan 7, 2022
@Eric-Arellano Eric-Arellano deleted the deprecate-validate-option branch January 7, 2022 20:31
@kaos
Copy link
Member

kaos commented Jan 7, 2022

The GoalSubsystem will be going away

Do you mean "the validate GoalSubsystem .." ?

@Eric-Arellano
Copy link
Contributor Author

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants