[internal] Add debug output for intermittent abort in poll_workunits
#14253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
changed the title
poll_workunitspoll_workunits
This was referenced Mar 3, 2022
[ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/log-in-poll-workunits-unwind
branch
from
b17c991
to
592476a
Compare
tdyas
approved these changes
Mar 3, 2022
Eric-Arellano
approved these changes
Mar 3, 2022
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Mar 3, 2022
…`. (pantsbuild#14253) Adds debug output to attempt to catch what we thought was a panic being converted into an abort, but which might just be an all-natural abort from another source. See PyO3/pyo3#2102 for some discussion of the relevant problem. Beyond just being debug output, this patch actually seems to avoid the issue for the user who was experiencing it. [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
Mar 3, 2022
…`. (cherrypick of #14253) (#14692) Adds debug output to attempt to catch what we thought was a panic being converted into an abort, but which might just be an all-natural abort from another source. See PyO3/pyo3#2102 for some discussion of the relevant problem. Beyond just being debug output, this patch actually seems to avoid the issue for the user who was experiencing it. [ci skip-build-wheels]
This was referenced Mar 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds debug output to attempt to catch what we thought was a panic being converted into an abort, but which might just be an all-natural abort from another source.
See PyO3/pyo3#2102 for some discussion of the relevant problem. Beyond just being debug output, this patch actually seems to avoid the issue for the user who was experiencing it.
[ci skip-build-wheels]