-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graduate Docker backend from experimental status. #14310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo!!! Epic
We can provide a much nicer upgrade experience for users by still keeping the experimental backend in 2.10. You'll have a register.py
in both the old place and new one. (If DRY bothers you, you can import from the new stable file)
There is probably a more elegant way to do this, but you can then add a function similar to this, and call it at the two call sites
pants/src/python/pants/option/global_options.py
Lines 1658 to 1664 in 27f23db
def maybe_warn_python_macros_deprecation(bootstrap_options: OptionValueContainer) -> None: | |
if ( | |
bootstrap_options.is_default("use_deprecated_python_macros") | |
and "pants.backend.python" in bootstrap_options.backend_packages | |
): | |
warn_or_error( | |
"2.11.0.dev0", |
I plan to possibly stabilize PyUpgrade & Autoflake, so I'll piggy back off of this helper.
There is probably a more elegant way to do this
Imo, quick and dirty gets the job done here. It's temporary code and this isn't used by plugin authors. End users don't care how we implement the deprecation.
Oh! Also |
Eh, look again ;) |
[ci skip-rust] [ci skip-build-wheels]
I didn't see the need for a custom deprecation method, I simply used the Gives me:
When used :) |
Oh cool! Perfect. |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
The Docker backend was introduced in Pantsbuild 2.7.0. It is now proven to be a functional backend for many common Docker use cases.