[internal] Add plugin hook for Go codegen support #14707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not sufficient for compiled languages. We'll need a new plugin hook instead. Still keep a dedicated rule for generating the source files though. That is nice for readability and testing. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
This comment was marked as outdated.
This comment was marked as outdated.
Eric-Arellano
commented
Mar 4, 2022
| ) | ||
|
|
||
| # Running directly on a codegen target should work. | ||
| assert_pkg_target_built( |
There was a problem hiding this comment.
Note that this triggers actual Go compilation - it works 🙌
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
tdyas
approved these changes
Mar 4, 2022
| ) | ||
|
|
||
| # Running directly on a codegen target should work. | ||
| assert_pkg_target_built( |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
force-pushed
the
go-codegen
branch
from
0b3f073
to
0026798
Compare
Closed
…e codegen # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
PTAL at the newest commit to make sure it's okay. I made the test more complex to ensure we can handle codegen depending on |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
tdyas
approved these changes
Mar 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14258. As described there, codegen for compiled languages is more complex because the generated code must be compiled, unlike Python where the code only needs to be present.
We still use the
GenerateSourcesRequestplugin hook to generate the raw.gofiles and so that integrations likeexport-codegengoal still work. But that alone is not powerful enough to know how to compile the Go code.So, we add a new Go-specific plugin hook. Plugin implementations return back the standardized type
BuildGoPackageRequest, which is all the information needed to compile a particular package, including by compiling its transitive dependencies. That allows for complex codegen modeling such as Protobuf needing the Protobuf third-party Go package compiled first, or Protobufs depending on other Protobufs.Rule authors can then directly tell Pants to compile that codegen (#14705), or it can be loaded via a
dependencyon a normalgo_package.