Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ./pants --version for pantsbuild.pants PEX #14963

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Fix ./pants --version for pantsbuild.pants PEX #14963

merged 1 commit into from
Mar 31, 2022

Conversation

Eric-Arellano
Copy link
Contributor

Closes #14938.

[ci skip-build-wheels]

@Eric-Arellano
Fix ./pants --version for pantsbuild.pants PEX
b72bbdd 
# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
Eric-Arellano
Eric-Arellano commented Mar 30, 2022
View reviewed changes
Copy link
Contributor Author

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not certain how to test this because wheels need to be built and uploaded. I'm thinking we merge then i test after those wheels are built? forward fix if necessary

@Eric-Arellano Eric-Arellano added the category:bugfix Bug fixes for released features label Mar 30, 2022
@stuhood stuhood added this to the 2.9.x milestone Mar 31, 2022
stuhood
stuhood approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Eric-Arellano Eric-Arellano merged commit 43b93d8 into pantsbuild:main Mar 31, 2022
@Eric-Arellano Eric-Arellano deleted the pex-version branch March 31, 2022 17:30
Eric-Arellano added a commit to Eric-Arellano/pants that referenced this pull request Mar 31, 2022
@Eric-Arellano
Fix ./pants --version for pantsbuild.pants PEX (pantsbuild#14963)
06dfb27 
Closes pantsbuild#14938.

[ci skip-rust]
Eric-Arellano added a commit to Eric-Arellano/pants that referenced this pull request Mar 31, 2022
@Eric-Arellano
Fix ./pants --version for pantsbuild.pants PEX (pantsbuild#14963)
1228f5a 
Closes pantsbuild#14938.

[ci skip-rust]
# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
Eric-Arellano added a commit to Eric-Arellano/pants that referenced this pull request Mar 31, 2022
@Eric-Arellano
Fix ./pants --version for pantsbuild.pants PEX (pantsbuild#14963)
fd73148 
Closes pantsbuild#14938.

[ci skip-rust]
# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@Eric-Arellano Eric-Arellano added category:internal CI, fixes for not-yet-released features, etc. and removed needs-cherrypick category:bugfix Bug fixes for released features labels Mar 31, 2022
@Eric-Arellano Eric-Arellano mentioned this pull request Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

@benjyw benjyw Awaiting requested review from benjyw

Assignees
No one assigned
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
2.9.x
Development

Successfully merging this pull request may close these issues.

Have to include SHA with pants version when using pants.pex
2 participants
@Eric-Arellano @stuhood