Optimize CreateDigest implementation.
#16617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use a `DigestTrie` to create all snapshots at once, instead of creating them individually * Store all in-memory file contents in a single (batched) call, instead of storing them individually [ci skip-build-wheels]
|
Omg epic. @stuhood definitely cherry-pick this to 2.14. Thoughts on 2.13? I'm hoping to do an RC tonight if I can get CI green. |
For sure |
It's not strictly needed, and skipping it can avoid a lot of IO. [ci skip-build-wheels]
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Aug 24, 2022
Closes pantsbuild#16570 * Use a `DigestTrie` to create all snapshots at once, instead of creating them individually * Store all in-memory file contents in a single (batched) call, instead of storing them individually [ci skip-build-wheels] --- I restored the benchmark script from pantsbuild#14569 to test this. | size | create_digest_before | create_digest_after | | --- | --- | --- | | 20000 | 608 | 130 | | 40000 | 1164 | 268 | | 60000 | 2260 | 475 | | 80000 | 3582 | 674 | | 100000 | 5085 | 862 | | 120000 | 6765 | 1057 | | 140000 | 8818 | 1067 | | 160000 | 10752 | 1361 | | 180000 | 12619 | 1604 |
Eric-Arellano
added a commit
that referenced
this pull request
Aug 29, 2022
Closes #16570 * Use a `DigestTrie` to create all snapshots at once, instead of creating them individually * Store all in-memory file contents in a single (batched) call, instead of storing them individually [ci skip-build-wheels] --- I restored the benchmark script from #14569 to test this. | size | create_digest_before | create_digest_after | | --- | --- | --- | | 20000 | 608 | 130 | | 40000 | 1164 | 268 | | 60000 | 2260 | 475 | | 80000 | 3582 | 674 | | 100000 | 5085 | 862 | | 120000 | 6765 | 1057 | | 140000 | 8818 | 1067 | | 160000 | 10752 | 1361 | | 180000 | 12619 | 1604 |
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
Closes pantsbuild#16570 * Use a `DigestTrie` to create all snapshots at once, instead of creating them individually * Store all in-memory file contents in a single (batched) call, instead of storing them individually [ci skip-build-wheels] --- I restored the benchmark script from pantsbuild#14569 to test this. | size | create_digest_before | create_digest_after | | --- | --- | --- | | 20000 | 608 | 130 | | 40000 | 1164 | 268 | | 60000 | 2260 | 475 | | 80000 | 3582 | 674 | | 100000 | 5085 | 862 | | 120000 | 6765 | 1057 | | 140000 | 8818 | 1067 | | 160000 | 10752 | 1361 | | 180000 | 12619 | 1604 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16570
DigestTrieto create all snapshots at once, instead of creating them individually[ci skip-build-wheels]
I restored the benchmark script from #14569 to test this. The results seem almost too good to be true, but here they are 🤔
Somebody should probably double-check those numbers 😅 I'll re-run on my machine to sanity-check it as well