Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_target upgrades sources to EagerFilesetWithSpec #5974

Merged

Commits on Jun 18, 2018

  1. make_target upgrades sources to EagerFilesetWithSpec

    This better simulates how the engine parses BUILD files, giving a more
    faithful experience in tests.
    
    I'm about to make it a warning/error to pass a list of strings as the
    sources arg, so this will make tests which use make_target continue to
    work after that.
    illicitonion committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    3697d0f View commit details
    Browse the repository at this point in the history
  2. Cloc test uses base class scheduler

    Instead of configuring its own.
    illicitonion committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    c9c864d View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2018

  1. Don't promote sources to EagerFilesetWithSpec

    This test is specifically testing invalidation for the list of strings case.
    illicitonion committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    7ededda View commit details
    Browse the repository at this point in the history
  2. Fix up comment

    illicitonion committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    a3ef62a View commit details
    Browse the repository at this point in the history