Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a --toolchain-variant option to select the compiler for C/C++ #6800

Merged
merged 28 commits into from
Dec 10, 2018
Merged

add a --toolchain-variant option to select the compiler for C/C++ #6800

merged 28 commits into from
Dec 10, 2018

Commits on Nov 30, 2018

  1. add a --toolchain-variant option to select the compiler for C/C++

    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    e78a483 View commit details
    Browse the repository at this point in the history

  2. add some logging around the compiler selection to validate toolchain … 

    …selection
    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    a799016 View commit details
    Browse the repository at this point in the history

  3. extend the exe checking to the link task

    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    71ca371 View commit details
    Browse the repository at this point in the history

  4. remove completed TODO

    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    bf9e9a7 View commit details
    Browse the repository at this point in the history

  5. add magic linking lib dirs args to gcc and make the other test work f… 

    …or both compilers
    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    363c940 View commit details
    Browse the repository at this point in the history

  6. add crti.o back to the command line 

    i think we were doing it wrong this whole time because we were only invoking llvm in our testing. a
mistake i hope we won't be able to make again.
    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    1de3799 View commit details
    Browse the repository at this point in the history

  7. refactor libc resolution and make tests pass on osx

    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    6ed4110 View commit details
    Browse the repository at this point in the history

  8. enable libc search in the link testing

    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    c4b4f28 View commit details
    Browse the repository at this point in the history

  9. use repr for debug logs

    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    ebeb2fa View commit details
    Browse the repository at this point in the history

  10. if this makes travis work finally we need to add a linter for this im… 

    …mediately
    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    282e9db View commit details
    Browse the repository at this point in the history

  11. fix error introduced by incorrect git rebase operation 

    the commit 082a1c0 was the product of a rebase, and this broke the
code in unexpected ways, leading to the CI failure. this is a very strange occurrence
    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    b53b5c0 View commit details
    Browse the repository at this point in the history

  12. try resetting the toolchain_variant to llvm for now and fix some tests

    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    7ee1dd9 View commit details
    Browse the repository at this point in the history

  13. move --tooldchain-variant to NativeToolchain to remove boilerplate in… 

    … NativeTask
    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    1b9804e View commit details
    Browse the repository at this point in the history

  14. make toolchain variant selection more declarative by moving the logic… 

    … into native_toolchain.py
    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    8375a62 View commit details
    Browse the repository at this point in the history

  15. separate extra object files from extra_args on the linker

    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    b32d643 View commit details
    Browse the repository at this point in the history

  16. pipe ToolchainVariantRequest into BuildLocalPythonDistributions

    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    1a2108d View commit details
    Browse the repository at this point in the history

  17. move from explicit crti.o file paths to adding it to the LIBRARY_PATH

    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    15632fe View commit details
    Browse the repository at this point in the history

  18. gcc on osx needs a bit more help to work at runtime

    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    0e3c3e8 View commit details
    Browse the repository at this point in the history

  19. enable search for libc so gcc can pass these tests

    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    0703beb View commit details
    Browse the repository at this point in the history

  20. fix the last couple tests

    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    6af5aca View commit details
    Browse the repository at this point in the history

  21. fill out ???s and link to issues for TODOs

    @cosmicexplorer
    cosmicexplorer committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    9a25d32 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2018

  1. expand docstrings and add types to Executable properties 

    also respond to various review comments
    @cosmicexplorer
    cosmicexplorer committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    64e3e54 View commit details
    Browse the repository at this point in the history

  2. remove some of the include dir dark magic by standardizing options 

    specifically remove the hardcoded extra include paths in the xcode clang wrapper
    @cosmicexplorer
    cosmicexplorer committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    5473093 View commit details
    Browse the repository at this point in the history

  3. add TODO links

    @cosmicexplorer
    cosmicexplorer committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    55e6908 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. don't add buggy include search flags to the clang invoke, and test bo… 

    …th toolchains in more tests
    @cosmicexplorer
    cosmicexplorer committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    3cd803a View commit details
    Browse the repository at this point in the history

  2. remove notes to self

    @cosmicexplorer
    cosmicexplorer committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    408f4cd View commit details
    Browse the repository at this point in the history

  3. remove remaining -nostdinc args and add a more concise TODO

    @cosmicexplorer
    cosmicexplorer committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    a3b4339 View commit details
    Browse the repository at this point in the history

  4. fix issue link

    @cosmicexplorer
    cosmicexplorer committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    45e4c7a View commit details
    Browse the repository at this point in the history