Expose an API to pass multiple Params to an engine request #6871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commits should be useful to review independently. |
ity
approved these changes
Dec 6, 2018
| This method should be called by exactly one scheduling thread, but the Step objects returned | ||
| by this method are intended to be executed in multiple threads, and then satisfied by the | ||
| scheduling thread. | ||
| :return: A tuple of (root, Return) tuples and (root, Throw) tuples. |
There was a problem hiding this comment.
i havent seen this return format before, but makes it a lot cleaner!
wisechengyi
reviewed
Dec 6, 2018
| if returns: | ||
| state = returns[0][1] | ||
| else: | ||
| state = throws[0][1] |
There was a problem hiding this comment.
Q:
- is it possible to have both returns and throws? in which case the logic seems to ignore throws.
- is there certain expectation on
execute's return value, e.g.len(throws) + len(returns) = len(request.roots)?
There was a problem hiding this comment.
Yes to your second question, so in this case: no to your first question.
stuhood
pushed a commit
that referenced
this pull request
Dec 6, 2018
### Problem As described in #5869, we need a way to consume `Options` in the new engine in order to provide access to `Subsystems` in `@rules`. ### Solution Convert `OptionsBootstrapper` and `Config` into `datatype`s in order to give them useful eq/hash implementations. Then, modify the `@rules` that were added in #5889 to consume the `Params` API added in #6871 and expose a `ScopedOptions` wrapper around the set of options for a `Scope`. ### Result `@rules` can consume `ScopedOptions`, although there should probably be built-in rules that can consume `ScopedOptions` to create `Subsystems`. Nonetheless, let's say that this "fixes #5869", and open a followup for actually exposing `Subsystems` to `@rules` in a generic way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Although consumption of multiple
Paramsis now supported, there is currently no way to actually provide them to a request. See #6478 for more info.Solution
Expose and test the ability to pass in a small
Paramsdatatype as a subject, which is flattened into a corresponding set of rust-sideParamsinadd_root_select.Result
Fixes #6478.