Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate implicit usage of binary_mode=True and mode='wb' in dirutil methods #7120

Merged
merged 14 commits into from
Feb 6, 2019
Merged

deprecate implicit usage of binary_mode=True and mode='wb' in dirutil methods #7120

merged 14 commits into from
Feb 6, 2019

Commits on Feb 6, 2019

  1. deprecate safe_file_dump() for safe_file_write(), which defaults to 'w'

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    01ce5ef View commit details
    Browse the repository at this point in the history

  2. deprecate implicit binary_mode=True for eventual py3 migration

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    f0a39c0 View commit details
    Browse the repository at this point in the history

  3. switch the order of mode and payload args in safe_file_write to avoid… 

    … errors
    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    84a95ac View commit details
    Browse the repository at this point in the history

  4. update the rest of the repo to avoid the new deprecations

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    49a660b View commit details
    Browse the repository at this point in the history

  5. fix up watchman testing

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    d2f4e88 View commit details
    Browse the repository at this point in the history

  6. add parens

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    06002f0 View commit details
    Browse the repository at this point in the history

  7. add issue link for post-py3 migration followup

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    1e525f4 View commit details
    Browse the repository at this point in the history

  8. empty strings are falsey in python!

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    7c0440a View commit details
    Browse the repository at this point in the history

  9. respond to review comments

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    7c42fe9 View commit details
    Browse the repository at this point in the history

  10. safe_file_write -> safe_file_dump

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    1468980 View commit details
    Browse the repository at this point in the history

  11. update TODO

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    c19889b View commit details
    Browse the repository at this point in the history

  12. respond to review comments

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    7619390 View commit details
    Browse the repository at this point in the history

  13. write_kwargs -> dump_kwargs!

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    0ac204b View commit details
    Browse the repository at this point in the history

  14. add ticket links

    @cosmicexplorer
    cosmicexplorer committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    2e67342 View commit details
    Browse the repository at this point in the history