Add flags to prosecc_executor that say where to materialize output and what is output #7201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Feb 4, 2019
| .long("materialize-output-to") | ||
| .takes_value(true) | ||
| .required(false) | ||
| .help("The name of a directory (which may or may not exist), and will copy the output tree there") |
There was a problem hiding this comment.
Suggested change
| .help("The name of a directory (which may or may not exist), and will copy the output tree there") | |
| .help("The name of a directory (which may or may not exist), where the output tree will be materialized.") |
| )) as Box<dyn process_execution::CommandRunner>, | ||
| }; | ||
| let mut rt = tokio::runtime::Runtime::new().unwrap(); | ||
| let result = rt.block_on(runner.run(request)).unwrap(); | ||
|
|
||
| if let Some(materialize_directory) = args.value_of("materialize-output-to").map(PathBuf::from) { |
There was a problem hiding this comment.
I'd probably call this variable output or materialize_directory_destination, rather than materialize_directory
| @@ -241,8 +274,8 @@ fn main() { | |||
| argv, | |||
| env, | |||
| input_files, | |||
| output_files: BTreeSet::new(), | |||
| output_directories: BTreeSet::new(), | |||
| output_files: output_file_path, | |||
There was a problem hiding this comment.
If you call these variables output_files and output_directories instead of output_file_path and output_directory_path, you can omit the : output_file_path part of this (like with input_files above), which is probably worth doing here because output_files and output_directories are completely meaningful names :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7180
Problem
The problem is described in #7180
Result
Added flags:
--materialize-output-to,--output-file-pathand--output-directory-path.If
--materialize-output-tois set the output tree will be copied there.